Open
Conversation
We depend on rust-lang/libc now because it has a larger set of types and constants than we do right now, and it includes a nice bit of infrastructure to support a wider array of architectures. We retained a small number of constants not currently included in libc.
Owner
|
Is there a reason that the tests can't pass without work on pthreads? I'm very hesitant to merge anything that would leave the master tests non-green. |
Collaborator
Author
|
@dikaiosune definitely do not merge this. I'm still working on this, and I will push up additional commits when ready. I just created this PR more-or-less to indicate what I'm working on |
Collaborator
Author
|
@dikaiosune btw, I'm pseudo-blocked here until I get That macro would make adding platform-specific assembly trivial: no build script hacks, no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We depend on rust-lang/libc now because it has a larger set of types and
constants than we do right now, and it includes a nice bit of
infrastructure to support a wider array of architectures.
We retained a small number of constants not currently included in libc.
Requires a rather substantial amount of pthreads work (cancelation, for example) before tests will pass.