$router.navigate to component

[gotenxds]

I was thinking it was quite odd that we cant navigate by component name and only by url, so I added the functionality.

You can now do this:

AppController.$routeConfig = [
  { path: '/',              redirectTo: '/welcome' },
  { path: '/welcome',       component: 'welcome' },
  { path: '/goodbye',       component: 'goodbye' }
];
function AppController($router) {
  $router.navigate('welcome');
}

You can still use the same function to navigate by url.

Currently the function tries by url, if none found it tries by component name.
Maybe this should be separated ?

$router.navigateToUrl('/welcome');
$router.navigateToComponent('welcome');

Your thoughts ?

[btford]

Needs corresponding tests, but otherwise looks alright!

[gotenxds]

I already added tests, If you think I missed some use cases let me know and I'll add them.

[btford]

I don't see any in the commits in this PR. Can you update your branch, maybe?

[gotenxds]

Amm this is wired, I guess I forgot to push that commit, I'll do that when I get home and update.

[gotenxds]

Hi, added a single test, couldn't think of any more uses cases that are not already being taken care of.

The build seems to be failing but that's not because of my commit (so awesome?).
Anyway, let me know what you think.

[gotenxds]

Rebased to master, build passes now.

[sdornan]

Shouldn't this be testing $router.navigate('one');?

[gotenxds]

indeed it should, I have fallen victim to the monster of copy&paste, Thanks :)

[sdornan]

👍

[hannahhoward]

awesome work! hope it gets merged.