Skip to content

Conversation

@calebegg
Copy link

Fixes #28067

@pullapprove pullapprove bot requested review from crisbeto and tjshiu January 20, 2026 20:52
@tjshiu tjshiu added dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release docs: preview When applied, a preview of the documentation site is deployed to Firebase labels Jan 20, 2026
Copy link
Contributor

@tjshiu tjshiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I like the change overall - but I do have a bit of a nit. The input is always on a new line here. Can we adjust it so that it isn't?

An alternative solution, but it would take more work: Add the role row and gridcell here and wrap the input. But I think it might not work because we wouldn't have the keyboard a11y for it (e.g. would still need to be able to arrow to the input). It would also pass the a11y checks but would be an issue for keyboard users since they are treated as separate tab stops.

@calebegg
Copy link
Author

I also dislike that the input is on a new line -- that was the exact functionality that led me to this example and to this bug.

But that seems to be a fundamental limitation of the component. I do not think code listed as example code should do funky things with roles to try to get a11y to work -- it should either be supported by the component or it shouldn't, and it's not, so I'm fixing the example to reflect that.

@adolgachev adolgachev self-requested a review January 22, 2026 01:38
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Deployed dev-app for 51c17d7 to: https://ng-dev-previews-comp--pr-angular-components-32679-dev-4g4jwctd.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Deployed docs-preview for 51c17d7 to: https://ng-dev-previews-comp--pr-angular-components-32679-docs-r9dwwmwc.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Contributor

@adolgachev adolgachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is fine as the goal here is to not have an example which fails the accessibility check and shows that something can not be actually done (without failing the checks).

We can explore doing a better example which does the right thing at a later point.

See b/475597223 for context as well.

@adolgachev
Copy link
Contributor

Check the lint error: use material/chips for the PR and commit.

@calebegg calebegg changed the title fix(chips): Example violates axe accessibility tests fix(material/chips): Example violates axe accessibility tests Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: material/chips dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(mat-chip-grid): when used with a matChipInput, element has children which are not allowed

3 participants