Conversation
Summary of ChangesHello @alkalescent, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Homebrew formula template to switch from using Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📦 Version Preview
When this PR is merged, version will be bumped to To change the bump type, include in commit message: |
There was a problem hiding this comment.
Code Review
The transition to uv for managing the Homebrew formula's installation is a positive change that improves build performance and ensures dependency reproducibility via the lockfile. I have identified a few necessary adjustments to the uv sync command to ensure it behaves correctly within the Homebrew build environment, specifically regarding the prevention of editable installs and the management of the uv cache directory.
| system libexec/"bin/pip", "install", buildpath.to_s | ||
|
|
||
| # Install project + locked dependencies from uv.lock (no resolver runs) | ||
| system "uv", "sync", "--frozen", "--no-dev", "--python", "python3.13" |
There was a problem hiding this comment.
By default, uv sync installs the project in editable mode. In the context of a Homebrew formula, the build directory is temporary and is deleted after the installation completes. An editable install would result in a broken package because the symlinks in the virtual environment would point to the non-existent build directory. Adding --no-editable ensures a standard, standalone installation.
system "uv", "sync", "--frozen", "--no-dev", "--no-editable", "--python", "python3.13"
| # Install the package and all dependencies | ||
| system libexec/"bin/pip", "install", "--upgrade", "pip", "setuptools", "wheel" | ||
| # Point uv's venv at Homebrew's libexec directory | ||
| ENV["UV_PROJECT_ENVIRONMENT"] = libexec.to_s |
There was a problem hiding this comment.
It is recommended to set UV_CACHE_DIR to a directory within the build sandbox (e.g., buildpath/".uv_cache"). This prevents uv from attempting to write to the default user cache directory, which may be restricted or cause permission issues in sandboxed or CI build environments.
ENV["UV_PROJECT_ENVIRONMENT"] = libexec.to_s
ENV["UV_CACHE_DIR"] = (buildpath/".uv_cache").to_s
No description provided.