Conversation
Summary of ChangesHello @alkalescent, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial fix for building Homebrew formulas, particularly for Python projects that rely on Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request attempts to fix the Homebrew formula by providing a version for builds from source tarballs. However, it incorrectly uses the environment variable for setuptools_scm (SETUPTOOLS_SCM_PRETEND_VERSION), while the project's pyproject.toml clearly indicates the use of hatch-vcs. My review corrects this by suggesting the use of the appropriate environment variable, HATCH_VCS_VERSION, and updating the corresponding comment to ensure the Homebrew installation works as intended.
| # Set version for setuptools_scm (GitHub tarballs lack .git metadata) | ||
| ENV["SETUPTOOLS_SCM_PRETEND_VERSION"] = "{{VERSION}}" |
There was a problem hiding this comment.
Your pyproject.toml specifies hatch-vcs as the version source, not setuptools_scm. hatch-vcs uses the HATCH_VCS_VERSION environment variable to set the version when Git metadata is unavailable, not SETUPTOOLS_SCM_PRETEND_VERSION.
The comment should also be updated to reflect that hatch-vcs is being used. This change is necessary for the Homebrew formula to correctly pick up the package version during installation.
# Set version for hatch-vcs (GitHub tarballs lack .git metadata)
ENV["HATCH_VCS_VERSION"] = "{{VERSION}}"
📦 Version Preview
When this PR is merged, version will be bumped to To change the bump type, include in commit message: |
1 participant
No description provided.