Skip to content

📃 fix(build): wordlist 📃#12

Merged
alkalescent merged 2 commits intomasterfrom
fix/wordlist
Jan 20, 2026
Merged

📃 fix(build): wordlist 📃#12
alkalescent merged 2 commits intomasterfrom
fix/wordlist

Conversation

@alkalescent
Copy link
Owner

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @alkalescent, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build configuration oversight by incorporating essential wordlist directories into the application's packaging process, thereby preventing runtime errors related to missing mnemonic data. Concurrently, it strengthens the project's reliability by introducing a comprehensive smoke test that verifies the accurate roundtrip conversion between BIP39 and SLIP39 mnemonic formats, specifically focusing on the digit-based representation of SLIP39 shares.

Highlights

  • Build Process Enhancement: The build script (scripts/build.sh) has been updated to explicitly include additional wordlist directories for mnemonic, hdwallet/mnemonics/bip39, and hdwallet/mnemonics/slip39. This ensures that all required wordlists are bundled correctly during the application build, resolving potential runtime issues related to missing mnemonic data.
  • New Roundtrip Smoke Test: A new smoke test, test_roundtrip, has been added to tests/smoke.py. This test validates the complete cycle of converting a BIP39 mnemonic to SLIP39 shares (using digit representation) and then reconstructing the original BIP39 mnemonic from these shares, ensuring data integrity and correct functionality. The new test is integrated into the main smoke test suite.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

📦 Version Preview

  • Current version: v1.1.9
  • Bump type: pre-minor
  • Release version: v1.2.0
  • TestPyPI version: v1.2.0-rc.0

When this PR is merged, version will be bumped to v1.2.0.

To change the bump type, include in commit message: #major, #minor, or #patch

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes the build process by including necessary wordlist files for various mnemonic libraries, ensuring the standalone executable works correctly. It also adds a new smoke test to verify the roundtrip conversion between BIP39 and SLIP39 mnemonics. My review focuses on improving the robustness of the new test case by addressing a potential resource leak with temporary file handling. The build script changes look correct.

@alkalescent alkalescent merged commit ade1c08 into master Jan 20, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant