-
Notifications
You must be signed in to change notification settings - Fork 1
DO-1743: add comprehensive PWA deployment workflow π #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheOrangePuff
wants to merge
4
commits into
main
Choose a base branch
from
feature/DO-1743_pwa-deployment-workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support S3 + CloudFront deployment with dual cache strategies - Branch-based preview environments with PR URLs - Multi-brand parallel deployment support - CloudFront invalidation with configurable paths - Node.js 16-22 support with Yarn/npm package managers - Environment-specific configurations (staging/production/preview) - Manual production deployment gates - Artifact caching and comprehensive cleanup - Extensive documentation with usage examples π€ Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
TheOrangePuff
commented
Aug 14, 2025
- Update environment parameter description to clarify it accepts any GitHub environment name - Remove hardcoded environment validation, rely on GitHub's environment protection rules - Clarify that cloudfront-signing-key is already optional (no change needed) - Multi-brand matrix build already implemented (no change needed)
- Remove cloudfront-signing-key from workflow secrets - Update README documentation to remove the secret
AdamJHall
approved these changes
Feb 11, 2026
Contributor
AdamJHall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one question about the validation
| brand-matrix: ${{ steps.brand-config.outputs.matrix }} | ||
| invalidation-paths: ${{ steps.cache-config.outputs.invalidation-paths }} | ||
| steps: | ||
| - name: Validate required inputs |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? If the inputs are marked as required won't github error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
π― Added a comprehensive Progressive Web Application deployment workflow that transforms how we deploy PWAs to AWS infrastructure
β’ π¦ Multi-environment deployments - Support for staging, production, and preview environments with proper isolation
β’ πΏ Branch-based preview environments - Automatic preview deployments for pull requests with unique URLs
β’ π Dual cache strategies - Smart caching with immutable assets (1 year) and revalidated HTML (1 hour)
β’ βοΈ CloudFront integration - Automatic cache invalidation with configurable paths for instant updates
β’ π·οΈ Multi-brand deployment support - Parallel deployment matrix for multiple brands in a single workflow
β’ π± Node.js 16-22 compatibility - Flexible package manager support (Yarn/npm) with proper dependency caching
β’ π‘οΈ Manual production gates - Environment-based deployment protection with approval workflows
β’ π§Ή Artifact optimization - Intelligent cleanup and storage optimization
πͺ Key Features That Make This Awesome
Smart Caching Strategy π§
The workflow implements a dual cache approach:
Preview Magic β¨
Every PR automatically gets its own preview environment:
pr-123orbranch-feature-nameprefixed deploymentsMulti-Brand Matrix Deployment π
Deploy multiple brands in parallel with a single configuration:
Enterprise-Grade AWS Integration π’
π¦ Usage Examples
Basic Production Deployment:
PR Preview Environment:
π§ What's Under the Hood
4-Stage Pipeline Architecture:
Input Validation & Safety:
Comprehensive Logging:
This workflow replaces ad-hoc deployment scripts and provides a standardized, battle-tested approach to PWA deployments across all our projects! π
π€ Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com