Merged
Conversation
3f7439c to
2c24dee
Compare
Test against Go 1.17 through 1.22 using a matrix strategy with nix. The shell.nix accepts a goPackage argument and maps versions to different nixpkgs pins: - pkgsCurrent (8c5066250910): go_1_21, go_1_22 - pkgs2305 (nixos-23.05): go_1_18, go_1_19, go_1_20 - pkgs2205 (nixos-22.05): go_1_17 Adds a "ci" rollup job that can be used as a single required check in branch protection rules. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2c24dee to
2e40a87
Compare
ajg
requested changes
Feb 1, 2026
Owner
ajg
left a comment
There was a problem hiding this comment.
Looks good; can just update the README please and go.mod?
- Update README to reflect Go 1.17 minimum requirement - Lower go.mod version to 1.17 to match CI matrix Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ajg
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goPackageargument (defaults togofor local dev)--arg goPackage "go_1_xx"to test each versionTest plan
nix-shellstill works with default Go🤖 Generated with Claude Code