This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Send the error over to the callback if decompress-zip fails#10343
Merged
ingorichter merged 1 commit intoadobe:masterfrom Jan 14, 2015
Merged
Send the error over to the callback if decompress-zip fails#10343ingorichter merged 1 commit intoadobe:masterfrom
ingorichter merged 1 commit intoadobe:masterfrom
Conversation
Contributor
|
LGTM. The formatting in the error dialog needs to be updated to provide a better location for the error message. |
ingorichter
added a commit
that referenced
this pull request
Jan 14, 2015
Send the error over to the callback if decompress-zip fails
Contributor
Author
|
I don't think there's a need to change the Brackets-internal error message (AFAIK, contrary to the registry, it only ever shows up when there's a real problem with the zip). And changing the server-side error message is part of adobe/brackets-registry#69. |
Contributor
|
I meant more the formatting of the error dialog. The error message could be more separated from the remaining text of the dialog box. |
Contributor
Author
|
So, do you mean the error dialog in Brackets itself or in the registry? |
Contributor
|
The error dialog in Brackets |
Contributor
|
|
Contributor
Author
|
@ingorichter Would you like to do the change or should I do it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for adobe/brackets-registry#69.