Skip to content

Conversation

@ninaceban
Copy link
Contributor

@ninaceban ninaceban commented Feb 10, 2026

Description

In previous version we were using for await(chunks in stream) which was causing issues in Safari. Safari does have support for for await syntax. The problem is that Safari's ReadableStream class does not implement Symbol.asyncIterator on its prototype.

The solution is to refactor the code to use stream.getReader() and while(true), catch, finally block.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.
  • I have added a Changeset (pnpm changeset) or it is not necessary because this PR is not consumer-facing.

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026

🦋 Changeset detected

Latest commit: 5e6735c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@carterworks carterworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run pnpm changeset, select @adobe/alloy, and write what you want to go on the public changelog file

Copy link
Member

@dompuiu dompuiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems ok. Please do what Carter asked.

As I already told you, there are some potential issues that could be fixed. I sent you the list on Slack.

Copy link
Collaborator

@jonsnyder jonsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you remove the hard-coded 10 seconds in this error message:

message: "Stream timeout: No data received within 10 seconds",

@ninaceban
Copy link
Contributor Author

Looks good. Can you remove the hard-coded 10 seconds in this error message:

message: "Stream timeout: No data received within 10 seconds",

sure

@jonsnyder jonsnyder dismissed carterworks’s stale review February 10, 2026 21:58

Nina finished what he was asking for.

@jonsnyder jonsnyder merged commit 98cdde5 into main Feb 10, 2026
6 checks passed
@jonsnyder jonsnyder deleted the safari-fix branch February 10, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants