feat: add brand and property registry lookup methods#130
Merged
Conversation
Add RegistryClient class for resolving domains to brands and properties via the AdCP registry API at agenticadvertising.org. - lookup_brand/lookup_brands for brand resolution (single + bulk) - lookup_property/lookup_properties for property resolution (single + bulk) - Auto-chunking for bulk requests exceeding 100 domains - Connection pooling with optional httpx.AsyncClient injection - ResolvedBrand and ResolvedProperty Pydantic response types - RegistryError exception for registry API failures Closes #129 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RegistryClientclass for resolving domains to brands and properties via the AdCP registry API (agenticadvertising.org)lookup_brand/lookup_brandsfor single and bulk brand resolutionlookup_property/lookup_propertiesfor single and bulk property resolutionResolvedBrandandResolvedPropertyPydantic response types (matching servertypes.ts)RegistryErrorexception for registry API failureshttpx.AsyncClientinjectionCloses #129
Test plan
pytest tests/test_registry.py -v— 43 tests passpytest tests/ -x -q— full suite passes (574 tests)ruff check— no lint errorsfrom adcp import RegistryClient, RegistryError, ResolvedBrand, ResolvedProperty🤖 Generated with Claude Code