feat: sync ADCP schema to 3.0.0-beta.3 with new operations and forecasting#127
Merged
feat: sync ADCP schema to 3.0.0-beta.3 with new operations and forecasting#127
Conversation
Sync schemas from ADCP 3.0.0-beta2 to latest tag (262 schemas, up from 210). Add list_accounts, sync_accounts, log_event, sync_event_sources, and get_creative_delivery operations across the full stack (client, protocols, server, CLI). Add 20+ discriminated union aliases for new response types. Fix preview_creative missing from ProtocolAdapter abstract base class. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Re-sync schemas to pick up CatalogMatch and MatchedGtin types added to core/product.json. Fix import sorting in types/__init__.py, add noqa comment to auto-generated _ergonomic.py to suppress I001, remove unused Assets5Model import from format_assets.py, and fix line length in test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Widen FormatAsset type alias to Any since the schema now generates 17+ discriminated union variants for format assets. Fix str type narrowing in preview_cache.py where dict.get() returned Optional incompatible with the inferred str type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ng types Sync with latest ADCP upstream schema. Key changes: - account_id is now optional on CreateMediaBuyRequest (seller uses agent's sole account when omitted) - Add 10 new forecasting schemas: daypart-target, delivery-forecast, forecast-point, forecast-range, and related enums - Updated targeting, proposal, product-allocation, and cpp-option schemas Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pin to explicit version tag instead of `latest`. Example data genericized (Coca-Cola/Publicis → Acme/Pinnacle) and $schema paths updated to versioned URLs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add preview_creative to server framework (base, mcp_tools, all subclass handlers) - Add all V3 operations to response_type_map for webhook parsing - Export 10 new forecasting types from types/__init__.py - Fix potential UnboundLocalError for debug_request in mcp.py - Add missing V3 aliases to adcp/__init__.py for consistency - Remove redundant branches in A2A response unwrapping - Add V3 operation hasattr checks to test_all_client_methods Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bokelley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_accounts,sync_accounts,log_event,sync_event_sources,get_creative_deliverypreview_creativeacross full server framework (was missing from server side)account_idoptional onCreateMediaBuyRequestDaypartTarget,DeliveryForecast,ForecastPoint,ForecastRange,DayOfWeek,DemographicSystem,ForecastMethod,ForecastRangeUnit,ForecastableMetric,ReachUnitresponse_type_mapfor webhook parsing (all V3 operations)adcp/__init__.pyfor consistencydebug_requestpotentialUnboundLocalErrorin MCP adapterTest plan
test_all_client_methodscovers all 34 operationsadcp.typesaccount_idconfirmed optional onCreateMediaBuyRequest🤖 Generated with Claude Code