Fix compatibility with cocotb v2.x#45
Open
Subhankar-hub wants to merge 1 commit intoadam-maj:masterfrom
Open
Conversation
- Update Makefile to use cocotb v2 API: - Replace `--prefix` with `--lib-dir` for cocotb-config - Rename `MODULE` to `COCOTB_TEST_MODULES` - Add required `PYGPI_PYTHON_BIN` environment variable - Fix test/helpers/setup.py: - Rename deprecated `units` parameter to `unit` in Clock() - Fix test/helpers/format.py: - Convert LogicArray values to int before arithmetic operations - Use `int(handle.value)` instead of deprecated `int(handle)` Tested with cocotb v2.0.1, Python 3.13, Icarus Verilog 12.0
Author
|
Please Review. |
Qianshui-Jiang
approved these changes
Jan 14, 2026
|
Same issue I've meet, thanks for your fix. |
Author
|
Glad I could help, p.s: used Cursor though 🙄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--lib-dir,COCOTB_TEST_MODULES,PYGPI_PYTHON_BIN)unitsparameter tounitinClock()LogicArrayvalues tointbefore arithmetic operationsProblem
The project doesn't work with cocotb v2.x due to API changes:
Test plan
make test_mataddpassesmake test_matmulpassesTested with cocotb v2.0.1, Python 3.13, Icarus Verilog 12.0