Merged
Conversation
plajjan
force-pushed
the
stress-test-mode
branch
from
8377c18 to
eed4ef6
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8377c1879d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
plajjan
force-pushed
the
stress-test-mode
branch
from
eed4ef6 to
847a22b
Compare
Acton's existing test flow is strong for functional correctness, but it can under-exercise concurrency faults when tests run in isolation. That is a blind spot for races in shared state, FFI boundaries, and C threading behavior where failures often require specific overlap timing. A dedicated stress mode is needed to repeatedly run the same test under coordinated parallel pressure so these bugs surface earlier and more reliably. This adds a dedicated stress testing mode to acton test and integrates it through the CLI parser, test runner, runtime test executor, and documentation. Stress mode runs one test function at a time at the outer runner layer, launches concurrent workers for that test, and skips reuse of cached results. Mode-specific defaults are now applied only when users omit flags: run keeps 50 ms behavior, perf defaults to 1 s, and stress defaults to --max-time 0 for continuous execution. The stress executor now uses sync and drift worker cohorts, performs calibration from measured iteration durations, applies startup offsets, and reports richer live telemetry. Continuous stress runs refine phase granularity over time and include observed phase-bin coverage. Interrupt handling was updated so Ctrl-C in stress mode returns valid partial results instead of failing the run. A dedicated test project under test/test_stress was added with simple, racy FFI, and stress-only segfault fixtures to exercise stress behavior. The Acton guide now includes a separate stress testing chapter and links from performance testing docs.
plajjan
force-pushed
the
stress-test-mode
branch
from
847a22b to
351e0cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acton's existing test flow is strong for functional correctness, but it can under-exercise concurrency faults when tests run in isolation. That is a blind spot for races in shared state, FFI boundaries, and C threading behavior where failures often require specific overlap timing. A dedicated stress mode is needed to repeatedly run the same test under coordinated parallel pressure so these bugs surface earlier and more reliably.
This adds a dedicated stress testing mode to acton test and integrates it through the CLI parser, test runner, runtime test executor, and documentation.
Stress mode runs one test function at a time at the outer runner layer, launches concurrent workers for that test, and skips reuse of cached results. Mode-specific defaults are now applied only when users omit flags: run keeps 50 ms behavior, perf defaults to 1 s, and stress defaults to --max-time 0 for continuous execution.
The stress executor now uses sync and drift worker cohorts, performs calibration from measured iteration durations, applies startup offsets, and reports richer live telemetry. Continuous stress runs refine phase granularity over time and include observed phase-bin coverage.
Interrupt handling was updated so Ctrl-C in stress mode returns valid partial results instead of failing the run.
A dedicated test project under test/test_stress was added with simple, racy FFI, and stress-only segfault fixtures to exercise stress behavior. The Acton guide now includes a separate stress testing chapter and links from performance testing docs.
Fixes #2577
Closes #1914