Integrate timing with progress UI & Fix progress status width overflow#2667
Merged
Integrate timing with progress UI & Fix progress status width overflow#2667
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6877ca52da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
added 2 commits
March 2, 2026 06:45
Clamp the rendered status field to the configured status column width so the elapsed-time column stays aligned even when status text grows. Adjust type-check status formatting to reserve space for the completed counter first and abbreviate only the current-name segment. This keeps the done/total count visible while still fitting within the status column.
Replace the old direct --timing prints with progress-UI integrated logging so output remains stable under concurrent builds and no longer garbles live lines. Front and back pass timings are now captured as structured data in the compile pipeline and emitted through the same locked path as module progress updates. Type checking now reports per-statement progress in execution order, including bind names for recursive groups and weighted progress based on bound-name count, so large groups contribute proportionally. The front-pass percentage model remains kinds at 10% and types at 90%, while statement-level completion drives the type-check portion. The timing detail layout is aligned with the normal timing column and prints concise per-statement lines with bind names on the line below. Indentation was tuned so Type stmt and binds lines read cleanly beneath each completed module entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the old direct --timing prints with progress-UI integrated logging so output remains stable under concurrent builds and no longer garbles live lines. Front and back pass timings are now captured as structured data in the compile pipeline and emitted through the same locked path as module progress updates.
Type checking now reports per-statement progress in execution order, including bind names for recursive groups and progress based on bound-name count, so large groups proportionally. The front-pass percentage model remains kinds 10% and types at 90%, while statement-level completion drives type-check portion.
The timing detail layout is aligned with the normal timing column and prints concise per-statement lines with bind names on the line below. Indentation was tuned so Type stmt and binds lines read cleanly beneath each completed module entry.
Clamp the rendered status field to the configured status column width so the elapsed-time column stays aligned even when status text grows.
Adjust type-check status formatting to reserve space for the completed counter first and abbreviate only the current-name segment. This keeps the done/total count visible while still fitting within the status column.