Skip to content

Integrate timing with progress UI & Fix progress status width overflow#2667

Merged
plajjan merged 2 commits intomainfrom
progress-width
Mar 2, 2026
Merged

Integrate timing with progress UI & Fix progress status width overflow#2667
plajjan merged 2 commits intomainfrom
progress-width

Conversation

@plajjan
Copy link
Contributor

@plajjan plajjan commented Mar 1, 2026

Replace the old direct --timing prints with progress-UI integrated logging so output remains stable under concurrent builds and no longer garbles live lines. Front and back pass timings are now captured as structured data in the compile pipeline and emitted through the same locked path as module progress updates.

Type checking now reports per-statement progress in execution order, including bind names for recursive groups and progress based on bound-name count, so large groups proportionally. The front-pass percentage model remains kinds 10% and types at 90%, while statement-level completion drives type-check portion.

The timing detail layout is aligned with the normal timing column and prints concise per-statement lines with bind names on the line below. Indentation was tuned so Type stmt and binds lines read cleanly beneath each completed module entry.

Clamp the rendered status field to the configured status column width so the elapsed-time column stays aligned even when status text grows.

Adjust type-check status formatting to reserve space for the completed counter first and abbreviate only the current-name segment. This keeps the done/total count visible while still fitting within the status column.

@plajjan plajjan enabled auto-merge March 1, 2026 14:04
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6877ca52da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Kristian Larsson added 2 commits March 2, 2026 06:45
Clamp the rendered status field to the configured status column width so the
elapsed-time column stays aligned even when status text grows.

Adjust type-check status formatting to reserve space for the completed counter
first and abbreviate only the current-name segment. This keeps the done/total
count visible while still fitting within the status column.
Replace the old direct --timing prints with progress-UI integrated
logging so output remains stable under concurrent builds and no
longer garbles live lines. Front and back pass timings are now
captured as structured data in the compile pipeline and emitted
through the same locked path as module progress updates.

Type checking now reports per-statement progress in execution
order, including bind names for recursive groups and weighted
progress based on bound-name count, so large groups contribute
proportionally. The front-pass percentage model remains kinds at
10% and types at 90%, while statement-level completion drives the
type-check portion.

The timing detail layout is aligned with the normal timing column
and prints concise per-statement lines with bind names on the line
below. Indentation was tuned so Type stmt and binds lines read
cleanly beneath each completed module entry.
@plajjan plajjan merged commit 7b61d2a into main Mar 2, 2026
39 of 42 checks passed
@plajjan plajjan deleted the progress-width branch March 2, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant