Fix AI Transport filter not working on page refresh/direct links#3166
Merged
Fix AI Transport filter not working on page refresh/direct links#3166
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
40c1f7f to
2d006ca
Compare
GregHolmes
approved these changes
Feb 2, 2026
The examples filter was using the products list from @ably/ui package which doesn't include ai_transport. Changed to use the local products definition that includes all example products including ai_transport.
2d006ca to
a4a25d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the AI Transport filter on the examples page not working when refreshing the page or using direct links with
?product=ai_transport.The issue was that the examples filter was using the
productsobject from@ably/ui/core/ProductTile/datato validate product query parameters. This external products list doesn't includeai_transport, so it was filtered out as invalid when parsing the URL on page load.The filter worked when clicked because the
ExamplesFiltercomponent uses the local products definition fromsrc/data/examples/index.ts.Changed
ExamplesContentto use the same local products definition for URL validation, which includes all example products includingai_transport.Review App
Checklist