Open
Conversation
dangmai
commented
Nov 19, 2023
| * @private | ||
| */ | ||
| const SECTION = new RegExp(/^\s*\[([^\]]+)]$/); | ||
| const SECTION = new RegExp(/^(?<indent>\s*)\[(?<sectionName>[^\]]+)]$/); |
Author
There was a problem hiding this comment.
I switch the RegExp to use named groups, so that it's easier to reference them later in the code (vs referencing by index number)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for both reading and writing multiline values.
There are multiple examples in Python's configparser docs about this scenario: https://docs.python.org/3/library/configparser.html#supported-ini-file-structure
I've tried to handle as many edge cases as I can based off of those examples. I've also added tests for a few example cases.
Fixes #4