Array changes for half#308
Open
PhilipDeegan wants to merge 2 commits intoX-DataInitiative:masterfrom
PhilipDeegan:half
Open
Array changes for half#308PhilipDeegan wants to merge 2 commits intoX-DataInitiative:masterfrom PhilipDeegan:half
PhilipDeegan wants to merge 2 commits intoX-DataInitiative:masterfrom
PhilipDeegan:half
Conversation
Mbompr
reviewed
Oct 16, 2018
Collaborator
|
Where were we with this one ? It's a pretty cool feature ! |
Member
Author
|
There's apparently some built in half_float in clang, and maybe else where, so I'm going to check that out |
Member
Author
|
Otherwise it works, we might want to look at some form of bounds checking as things get a little strange after 3/4 decimal places |
Member
Author
|
clang seems to have support for float16 - perhaps we could right some tests based on that and make the other lib adhere? |
Member
Author
|
seems that clang fl16 only works on ARM :| |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@andro2157 kudos to