Use inner value of Box (#63).#64
Merged
AnthonyMichaelTDM merged 2 commits intoWulf:mainfrom Nov 12, 2025
Merged
Conversation
Add tests that cover Box values
AnthonyMichaelTDM
approved these changes
Oct 30, 2025
Collaborator
AnthonyMichaelTDM
left a comment
AnthonyMichaelTDM
left a comment
There was a problem hiding this comment.
This looks good to me, do you think we should do the same thing with other smart pointers like Arc, Rc, etc. @Wulf ?
Collaborator
|
I wonder why the CI isn't running, maybe it's bc the commit isn't verified? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63
Added Box as a value that just uses the inner value.
Added tests that cover this issue.