Fix new rust & clippy warnings; Simplify CI#146
Merged
Conversation
new warning in latest rust
instead of manually calling rustup
it was basically that version already according to lib.rs
longsleep
approved these changes
Sep 6, 2025
Collaborator
longsleep
left a comment
There was a problem hiding this comment.
Lgtm - with the bump of the Rust version to 1.70 maybe the next release should reflect that by going to 0.2.0.
Collaborator
Author
I dont think we advertised any rust version before.
Along with some other changes, we can make it a 02.0 |
Collaborator
Author
|
Accidentally closed, pushed the wrong button instead of "Comment".
I dont think we advertised a rust version before and i didnt test any lower version, but along with some other changes this will be 0.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes new warnings by rust and clippy and also simplifies the CI workflow by:
Swatinem/rust-cachefor our caching needsFinally, set a MSRV as listed on lib.rs (older may work, but didnt test)