Closed
Conversation
hasezoey
requested changes
Oct 29, 2023
Collaborator
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
some things i noticed.
also converting this pr to WIP because of requirements
|
|
||
| Currently, it's more advantageous to generate code over deriving code with macros because intellisense and autocompletion isn't quite there when it comes to macro expansion. | ||
|
|
||
| **Migrating from v0 to v1? See migration notes below.** |
Collaborator
There was a problem hiding this comment.
Suggested change
| **Migrating from v0 to v1? See migration notes below.** | |
| **Migrating from v0 to v1? See [migration notes below](#migrating-from-v0-to-v1).** |
Note that i have not checked the slug, but it should likely be this
| - Supports `diesel-async` (enable `async` feature flag) | ||
| - Generates structs based on your `schema.rs` file (see the `test/simple_table` folder for sample output) | ||
| - Optionally generates CRUD functions and helper methods | ||
| - Use as a binary or library (read more below) |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Use as a binary or library (read more below) | |
| - Usable as a binary or library (read more below) |
i think this reads better with better understanding
| Now we have everything we need! | ||
|
|
||
| ```rust | ||
| use models::todos; |
Collaborator
There was a problem hiding this comment.
why remove that line? i think this would make sense to get to know where some things come from
| /* | ||
| CRUD examples | ||
| */ | ||
| let created_todo = todos::create(&mut db, todos::CreateTodo { |
Collaborator
There was a problem hiding this comment.
Suggested change
| let created_todo = todos::create(&mut db, todos::CreateTodo { | |
| let created_todo = Todo::create(&mut db, todos::CreateTodo { |
unless i missed something, this should likely be the actual case (error from before this PR)
| let updated_todo = todos::update(&mut db, created_todo.id, UpdateTodo { | ||
| })?; | ||
|
|
||
| let todos_list = Todo::paginate(db, 1, 10)?; |
Collaborator
There was a problem hiding this comment.
if this PR requires #103, then shouldnt this take one more parameter?
| /* | ||
| CRUD examples | ||
| */ | ||
| let created_todo = todos::create(&mut db, todos::CreateTodo { |
Collaborator
There was a problem hiding this comment.
Suggested change
| let created_todo = todos::create(&mut db, todos::CreateTodo { | |
| let created_todo = todos::create(&mut db, CreateTodo { |
also to be consistent with later calls
| Use the "Filter" helper | ||
| --> Works well with intellisense! <-- | ||
| --> Easily create reusable/portable queries! <-- | ||
| (Support for date/time and other types coming soon) |
Collaborator
There was a problem hiding this comment.
what support is missing?
Comment on lines
+184
to
+185
| ## Migrating from v0 to v1 | ||
| * For those that use plural table names: English-based pluralization is no longer handled. If you had a table named `todos`, dsync will not generate a struct named `Todo` anymore, but instead, `struct Todos` will be generated. It might be easier to rename your tables entirely to singular case. |
Collaborator
There was a problem hiding this comment.
Suggested change
| ## Migrating from v0 to v1 | |
| * For those that use plural table names: English-based pluralization is no longer handled. If you had a table named `todos`, dsync will not generate a struct named `Todo` anymore, but instead, `struct Todos` will be generated. It might be easier to rename your tables entirely to singular case. | |
| ## Migrating from v0 to v1 | |
| * For those that use plural table names: English-based pluralization is no longer handled. If you had a table named `todos`, dsync will not generate a struct named `Todo` anymore, but instead, `struct Todos` will be generated. It might be easier to rename your tables entirely to singular case. |
Owner
Author
|
I'm going to close this -- we can always reference it later if needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #104 which requres #103!