Add missing PromptBuilder convenience wrappers to control media output#218
Add missing PromptBuilder convenience wrappers to control media output#218felixarntz wants to merge 1 commit intotrunkfrom
PromptBuilder convenience wrappers to control media output#218Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #218 +/- ##
============================================
+ Coverage 87.45% 87.48% +0.02%
- Complexity 1194 1197 +3
============================================
Files 60 60
Lines 3858 3867 +9
============================================
+ Hits 3374 3383 +9
Misses 484 484
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@JasonTheAdams One other thing to consider here is that we also don't support setting custom options via Maybe that's still a reasonable path forward, because using those is more advanced and assumes extra responsibility on the caller - they will need to know whether the API supports a specific custom option or not - but I wanted to bring it up so we can consider whether or not to add a convenience method for them. If we want to include that in the |
The
PromptBuilderwas missing methods to control 3ModelConfigproperties:outputMediaOrientationoutputMediaAspectRatiooutputSpeechVoiceAdditionally, this PR fixes an odd but somewhat important bug with the
usingStopSequencesmethod not working at all (it needs to set the top-level key, not a key incustomOptions).