Custom Template Path Webpack Plugin: Rewrite as CommonJS

[aduth]

Extracted from: #15226

This pull request seeks to expose the source of CustomTemplatedPathWebpackPlugin directly as its source, omitting it from the Babel transpilation build step. The proposed benefit is to reduce overhead by limiting the number of Babel-transpiled packages, to accurately reflect the current source as being CommonJS and, depending on the outcome of #15226, avoid dependencies on a built package from the project's own build tooling (Webpack). The main downside is fragmentation on which packages are and aren't transpiled by Babel.

Testing instructions:

Verify build succeeds:

npm run build

[youknowriad]

Same questions as #15710

[gziolo]

How about the lock file? It should get updated as well.

[gziolo]

My comment from the second similar PR:

See: https://medium.com/@nodejs/announcing-a-new-experimental-modules-1be8d2d6c2ff

Add “type”: “module” to the package.json for your project, and Node.js will treat all .js files in your project as ES modules.

There is also commonjs value proposed.

We should add this new field to all packages and start using it with the script which picks which packages should be transpiled. This is going to solve the issue with special handling for src folder.

[aduth]

Resolved package-lock.json in rebased 9f8f063.

[aduth]

We should add this new field to all packages and start using it with the script which picks which packages should be transpiled. This is going to solve the issue with special handling for src folder.

Do we have a related issue for this? It has some other impact on how Node treats code that we might want to be considerate of (e.g. safe to direct build-module/index.js as main?).

[gziolo]

We should add this new field to all packages and start using it with the script which picks which packages should be transpiled. This is going to solve the issue with special handling for src folder.

Do we have a related issue for this? It has some other impact on how Node treats code that we might want to be considerate of (e.g. safe to direct build-module/index.js as main?).

I haven’t created one yet. ES modules in Node 12 are still behind the flag. You can’t safely use them in CLI scripts in our setup. However we can add this new field for future usage and to better describe the type of package.