Aquarium fails if webgl2 not available#44
Open
GKraats wants to merge 1 commit intoWebGLSamples:masterfrom
Open
Aquarium fails if webgl2 not available#44GKraats wants to merge 1 commit intoWebGLSamples:masterfrom
GKraats wants to merge 1 commit intoWebGLSamples:masterfrom
Conversation
Merged
Contributor
|
For what it's worth, I did some cursory testing in various browsers and this doesn't seem to break anything. |
Author
|
It would be nice if this pull-request finally becomes merged. Aquarium is the first application at https://webglsamples.org/ and it is a very nice one. It now shows the misleading message : "It does not appear your computer supports WebGL", even if WebGL is available and only WebGL2 not. At Google "aquarium WebGL not supported" problems still are reported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem is caused by recent merge #42.