Improve report generation flow and delivery controls#61
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves report generation by fixing duplicate ticket ID rendering, standardizing report filenames to use Monday (week-start) dates, adding flexible delivery controls via command arguments, and introducing proactive manager notifications when team members submit reports.
Changes:
- Fixed duplicate ticket ID prefix rendering in team and boss reports through a new deduplication helper
- Changed report filename date suffix from Friday to Monday (week-start) for consistency
- Added argument parsing to
/generate-reportfor mode (team/boss) and delivery (private/channel), replacing the staticreport_privateconfig
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/report/report_builder.go | Added canonicalTicketIDs and stripLeadingTicketPrefixIfSame helpers to deduplicate ticket prefixes; updated formatTeamItem/formatBossItem to use new helpers; changed filename date from Friday to Monday |
| internal/report/report_builder_test.go | Added test for ticket ID deduplication; updated test date variables from friday to weekStart |
| internal/integrations/slack/slack.go | Added notifyManagersOnMemberReport and buildManagerReportNotificationMessage for manager notifications; added parseGenerateReportArgs to parse optional command arguments; replaced cfg.ReportPrivate with per-invocation sendPrivate parameter |
| internal/integrations/slack/slack_logic_test.go | Added comprehensive tests for parseGenerateReportArgs; updated test date variables from friday to weekStart |
| internal/integrations/slack/functional_slack_github_test.go | Added newMockSlackAPIWithManagerNotify mock and two tests validating manager notifications |
| internal/config/config.go | Removed ReportPrivate field and REPORT_PRIVATE env override |
| config.yaml | Removed report_private config option and documentation comment |
| README.md | Updated command documentation to show new argument syntax; removed report_private config documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Examples
Tests