This repository was archived by the owner on May 24, 2023. It is now read-only.
Add code comment to ease understanding#105
Open
twoi wants to merge 1 commit intoVividCortex:gh-pagesfrom
Open
Conversation
As I'm [not the only one](VividCortex#70) who stumbled upon this, let's just add a comment to the example code. No logging library I have worked with goes as far as terminating the program, so many go beginners may not understand this - although I think it does make sense. (Otherwise - what's the meaning of "fatal"?)
gkristic-vc
reviewed
Apr 21, 2020
gkristic-vc
left a comment
gkristic-vc
left a comment
There was a problem hiding this comment.
True, just like any deferred function, rows.Close won't be called if the application aborts. Not sure why this would be a problem, though. Maybe we could change all log.Fatal to return? It's not the point in the example anyway. (See also the last paragraph here.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I'm not the only one who stumbled upon this, let's just add a comment to the example code.
No logging library I have worked with goes as far as terminating the program, so many go beginners may not understand this - although I think it does make sense. (Otherwise - what's the meaning of "fatal"?)