DeepLink: port redesigned generic-request UI screens#231
DeepLink: port redesigned generic-request UI screens#231Meyse wants to merge 11 commits intoVerusCoin:generic-request-changesfrom
Conversation
Meyse
force-pushed
the
codex/ui-generic-request-redesign
branch
from
cbb2cef to
eb6316f
Compare
michaeltout
left a comment
michaeltout
left a comment
There was a problem hiding this comment.
Thanks for PR, looking good, but needs some changes, feel free to ask any questions or DM me.
| } | ||
| } | ||
|
|
||
| const styles = StyleSheet.create({ |
There was a problem hiding this comment.
Please move stylesheets into src/styles and import them from the individual components, so they can be reused. E.g. searchContainer can be added to src/styles/containers.styles.js etc.
There was a problem hiding this comment.
You may have to rename some things like container to be more specific, e.g. flexZeroContainer or something.
| } | ||
| } | ||
|
|
||
| openIdDetails = () => { |
There was a problem hiding this comment.
Why remove verusID lookup functionality?
src/components/GradientButton.js
Outdated
| ); | ||
| }; | ||
|
|
||
| const styles = StyleSheet.create({ |
There was a problem hiding this comment.
Same note about stylesheets as above
src/components/VerusIdObjectData.js
Outdated
|
|
||
| const triangle = <MaterialCommunityIcons name={'information'} size={20} color={Colors.warningButtonColor} style={{ width: 20, marginRight: 9, alignSelf: 'flex-end', }} />; | ||
|
|
||
| const LocalStyles = StyleSheet.create({ |
src/components/VerusIdObjectData.js
Outdated
| if (!obj || typeof obj !== 'object' || Array.isArray(obj)) return false; | ||
| const keys = Object.keys(obj); | ||
| if (keys.length !== 1) return false; | ||
| return getVDXFKeyLabel(keys[0], true) === 'content multi map remove'; |
There was a problem hiding this comment.
To check if an object is a remove, just check keys[0] === ContentMultiMapRemoveKey.vdxfid, it is better than checking against the label value hardcoded like this because the label might change in the future, check the key instead.
| ); | ||
| }; | ||
|
|
||
| const connectorStyles = { |
There was a problem hiding this comment.
Refer to earlier comment regarding stylesheet location
| VERUSID_STATUS, | ||
| } from '../../../../utils/constants/verusidObjectData'; | ||
|
|
||
| const HIGH_RISK_KEYS = new Set([ |
There was a problem hiding this comment.
I would add private addr to this, as people might send funds there
| ); | ||
| }; | ||
|
|
||
| const styles = StyleSheet.create({ |
Centralize deeplink and shared component styles, tighten authentication and identity update request handling, and add the provision identity details handler. Also rebuild react-native-verus iOS assets during pod install, update the package patch and lockfiles, and remove the bundled Yarn 1 repo config.
Bring in the latest API-auth and unsigned generic request validation changes from VerusCoin's generic-request-changes branch while keeping AGENTS.md and yarn.lock out of this merge. Also carry the related package.json updates and new URL auth helper used by VRPC callers.
2 participants
No description provided.