fix: use na_rep instead of string 'None' for missing score and count data in CSV export#661
Open
bencap wants to merge 2 commits intorelease-2026.1.1from
Open
Conversation
…data in CSV export
The scores and counts loops in variant_to_csv_row were calling str() on
None values without a null check, producing the literal string "None"
instead of the na_rep value ("NA"). Other column handlers (core, mavedb,
vep, gnomad, clingen) already had null checks — this adds the same
is_null guard to scores and counts.
…das for 3.12 support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scores and counts loops in variant_to_csv_row were calling str() on None values without a null check, producing the literal string "None" instead of the na_rep value ("NA"). Other column handlers (core, mavedb, vep, gnomad, clingen) already had null checks — this adds the same is_null guard to scores and counts.
Additionally, bumps Pandas to >=2.2 to resolve issues with removed setup_tools libs.