Modify paramdump to use trigger service

[rohbotics]

I made it a more "ROS-Like" interface for it.

This PR will change the public interface of the code, so it might make sense to hold off on merging until the other code that interfaces with it is also modified.

Let me know what you think.

[jrlandau]

I agree with you. It doesn't make sense to change one side of an interface without changing the other. If I remember correctly, there is one call to paramdump in Robot Commander and one in Speech Commands.

…

On Sat, Jul 8, 2017 at 10:50 PM, Rohan Agrawal ***@***.***> wrote: I made it a more "ROS-Like" interface for it. This PR will change the public interface of the code, so it might make sense to hold off on merging until the other code that interfaces with it is also modified. Let me know what you think. ------------------------------ You can view, comment on, or merge this pull request online at: #1 Commit Summary - remove old tmp files - remove custom message - cleanup code to use std_srvs/Trigger service File Changes - *M* CMakeLists.txt <https://github.com/UbiquityRobotics/paramdump/pull/1/files#diff-0> (18) - *D* launch/speech.launch~ <https://github.com/UbiquityRobotics/paramdump/pull/1/files#diff-1> (9) - *D* launch/testspeech.launch~ <https://github.com/UbiquityRobotics/paramdump/pull/1/files#diff-2> (9) - *D* msg/paramdump.msg <https://github.com/UbiquityRobotics/paramdump/pull/1/files#diff-3> (2) - *D* msg/paramdump.msg~ <https://github.com/UbiquityRobotics/paramdump/pull/1/files#diff-4> (0) - *D* scripts/.paramdump.py.swp <https://github.com/UbiquityRobotics/paramdump/pull/1/files#diff-5> (0) - *D* scripts/gains.yaml <https://github.com/UbiquityRobotics/paramdump/pull/1/files#diff-6> (2) - *M* scripts/paramdump.py <https://github.com/UbiquityRobotics/paramdump/pull/1/files#diff-7> (38) Patch Links: - https://github.com/UbiquityRobotics/paramdump/pull/1.patch - https://github.com/UbiquityRobotics/paramdump/pull/1.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADxmjEUcUzc5wWEBwZOqjJLrGViGgchuks5sMGoNgaJpZM4OR90H> .