Open
Conversation
orhun
approved these changes
Nov 9, 2024
orhun
left a comment
orhun
left a comment
There was a problem hiding this comment.
LGTM!
I think we should bump Ratatui to 0.29 though :)
Author
good point, i will look at that |
|
@Smurphy000 hello, thanks for the update. Could you bump to 0.29 and merge? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seemed to be some breaking changes between
0.26and0.28ofratatui.Currently I am experimenting with adding browser support to the terminal application I built on
0.28and these are the adjustments I had to make so far to getwebatuiand its examples running, so I wanted to send them over.Feel free to disregard if there are no plans for further changes here. Thank you 😄