Skip to content

Supressed "Failed to verify the request's HTTP Signatures."#1617

Merged
rmgpinto merged 1 commit intomainfrom
suppress-http-signatures-log
Feb 26, 2026
Merged

Supressed "Failed to verify the request's HTTP Signatures."#1617
rmgpinto merged 1 commit intomainfrom
suppress-http-signatures-log

Conversation

@rmgpinto
Copy link
Collaborator

ref https://linear.app/ghost/issue/BER-3241

  • We log the 410 and that should be enough to determine the request failed.

@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc7c5c6 and b2aa421.

📒 Files selected for processing (1)
  • src/app.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/app.ts

Walkthrough

A new log filter suppressHttpSignatureVerification was added to the root logger configuration in src/app.ts. The filter excludes log records whose message, when joined, contains "Failed to verify the request's HTTP Signatures". This filter is applied to the fedify logger to suppress those specific HTTP signature verification failure messages. No control flow or error handling changes were introduced.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: suppressing a specific log message about HTTP signature verification failures.
Description check ✅ Passed The description is related to the changeset, explaining the rationale for suppressing the log message and referencing an issue tracker.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch suppress-http-signatures-log

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ref https://linear.app/ghost/issue/BER-3241

- We log the 410 and that should be enough to determine the request
failed.
@rmgpinto rmgpinto force-pushed the suppress-http-signatures-log branch from fc7c5c6 to b2aa421 Compare February 25, 2026 16:55
@rmgpinto rmgpinto merged commit d98fa25 into main Feb 26, 2026
12 checks passed
@rmgpinto rmgpinto deleted the suppress-http-signatures-log branch February 26, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant