Skip to content

Update Types packages (major)#1572

Open
renovate[bot] wants to merge 1 commit intomainfrom
renovate/major-types-packages
Open

Update Types packages (major)#1572
renovate[bot] wants to merge 1 commit intomainfrom
renovate/major-types-packages

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Feb 9, 2026

This PR contains the following updates:

Package Change Age Confidence
@types/node (source) 20.19.3324.10.13 age confidence
@types/sinon (source) 17.0.421.0.0 age confidence
@​types/uuid 10.0.011.0.0 age confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - Between 07:00 AM and 04:59 PM, only on Monday, Tuesday, Wednesday, and Thursday ( * 7-16 * * 1,2,3,4 ) (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/major-types-packages branch 4 times, most recently from 2deb8c6 to 861752e Compare February 13, 2026 15:29
@sagzy sagzy requested a review from Copilot February 15, 2026 17:25
@sagzy
Copy link
Contributor

sagzy commented Feb 15, 2026

@codex review

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates TypeScript type definition packages via Renovate to newer major versions, refreshing Node/Sinon/UUID typings used by the ActivityPub TypeScript codebase.

Changes:

  • Bump @types/node from 20.19.33 to 24.10.13
  • Bump @types/sinon from 17.0.4 to 21.0.0
  • Bump @types/uuid from 10.0.0 to 11.0.0 (and update lockfile transitive deps accordingly)

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
package.json Updates the pinned major versions of the @types/* devDependencies.
yarn.lock Reflects the updated @types/* resolutions and new transitive dependencies (notably uuid@*).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"@types/html-to-text": "9.0.4",
"@types/jsonwebtoken": "9.0.10",
"@types/node": "20.19.33",
"@types/node": "24.10.13",
Copy link

Copilot AI Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/node is being bumped to a Node 24.x typing set while the repo’s runtime Node version appears to be 22.22.0 (see .nvmrc and Dockerfile base image). This can make TypeScript accept newer Node APIs that won’t exist at runtime and may introduce subtle type mismatches; consider pinning @types/node to the supported Node major (e.g., 22.x) or updating the repo’s Node runtime/version policy in the same change.

Suggested change
"@types/node": "24.10.13",
"@types/node": "22.10.2",

Copilot uses AI. Check for mistakes.
"@types/sinon": "17.0.4",
"@types/uuid": "10.0.0",
"@types/sinon": "21.0.0",
"@types/uuid": "11.0.0",
Copy link

Copilot AI Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating @types/uuid to 11.0.0 introduces a new transitive dependency on uuid "*", which in the lockfile resolves to an additional uuid@13.0.0 alongside the existing direct dependency uuid@10.0.0. This increases dependency surface area and can lead to mismatched runtime vs. typing expectations; consider either keeping @types/uuid at a version that doesn’t pull uuid, adding a Yarn resolution to force the transitive uuid to the same version as your direct dependency, or upgrading the direct uuid dependency to match.

Suggested change
"@types/uuid": "11.0.0",
"@types/uuid": "10.0.0",

Copilot uses AI. Check for mistakes.
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 861752ed81

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"@types/html-to-text": "9.0.4",
"@types/jsonwebtoken": "9.0.10",
"@types/node": "20.19.33",
"@types/node": "24.10.13",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align @types/node with deployed Node major

Updating @types/node to 24.x makes the compiler accept Node 24-only APIs while this service is still built and run on Node 22 (Dockerfile line 1), so type checks can now pass for code that will fail at runtime in production. Keeping Node typings on the same major as the deployed runtime prevents this class of false-negative compatibility checks.

Useful? React with 👍 / 👎.

@renovate renovate bot force-pushed the renovate/major-types-packages branch from 861752e to 0afab76 Compare February 17, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants