Conversation
2deb8c6 to
861752e
Compare
|
@codex review |
There was a problem hiding this comment.
Pull request overview
Updates TypeScript type definition packages via Renovate to newer major versions, refreshing Node/Sinon/UUID typings used by the ActivityPub TypeScript codebase.
Changes:
- Bump
@types/nodefrom20.19.33to24.10.13 - Bump
@types/sinonfrom17.0.4to21.0.0 - Bump
@types/uuidfrom10.0.0to11.0.0(and update lockfile transitive deps accordingly)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Updates the pinned major versions of the @types/* devDependencies. |
| yarn.lock | Reflects the updated @types/* resolutions and new transitive dependencies (notably uuid@*). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@types/html-to-text": "9.0.4", | ||
| "@types/jsonwebtoken": "9.0.10", | ||
| "@types/node": "20.19.33", | ||
| "@types/node": "24.10.13", |
There was a problem hiding this comment.
@types/node is being bumped to a Node 24.x typing set while the repo’s runtime Node version appears to be 22.22.0 (see .nvmrc and Dockerfile base image). This can make TypeScript accept newer Node APIs that won’t exist at runtime and may introduce subtle type mismatches; consider pinning @types/node to the supported Node major (e.g., 22.x) or updating the repo’s Node runtime/version policy in the same change.
| "@types/node": "24.10.13", | |
| "@types/node": "22.10.2", |
| "@types/sinon": "17.0.4", | ||
| "@types/uuid": "10.0.0", | ||
| "@types/sinon": "21.0.0", | ||
| "@types/uuid": "11.0.0", |
There was a problem hiding this comment.
Updating @types/uuid to 11.0.0 introduces a new transitive dependency on uuid "*", which in the lockfile resolves to an additional uuid@13.0.0 alongside the existing direct dependency uuid@10.0.0. This increases dependency surface area and can lead to mismatched runtime vs. typing expectations; consider either keeping @types/uuid at a version that doesn’t pull uuid, adding a Yarn resolution to force the transitive uuid to the same version as your direct dependency, or upgrading the direct uuid dependency to match.
| "@types/uuid": "11.0.0", | |
| "@types/uuid": "10.0.0", |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 861752ed81
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@types/html-to-text": "9.0.4", | ||
| "@types/jsonwebtoken": "9.0.10", | ||
| "@types/node": "20.19.33", | ||
| "@types/node": "24.10.13", |
There was a problem hiding this comment.
Align @types/node with deployed Node major
Updating @types/node to 24.x makes the compiler accept Node 24-only APIs while this service is still built and run on Node 22 (Dockerfile line 1), so type checks can now pass for code that will fail at runtime in production. Keeping Node typings on the same major as the deployed runtime prevents this class of false-negative compatibility checks.
Useful? React with 👍 / 👎.
861752e to
0afab76
Compare
This PR contains the following updates:
20.19.33→24.10.1317.0.4→21.0.010.0.0→11.0.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - Between 07:00 AM and 04:59 PM, only on Monday, Tuesday, Wednesday, and Thursday ( * 7-16 * * 1,2,3,4 ) (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.