Conversation
Try
left a comment
There was a problem hiding this comment.
Hi, @psjuan97 and thanks for PR!
It doesn't look as bad as was was expecting from android, however how do you handle AndroidManifest.xml / gradle / .java ? I'm pretty sure, that you shown manifest on discord discussion, but I don't see it in PR.
game/main.cpp
Outdated
| } | ||
|
|
||
| #if defined(__ANDROID__) | ||
| extern "C" void android_main(struct android_app* app) { |
There was a problem hiding this comment.
Need to move into Tempest, as it's an implementation detail.
game/utils/installdetect.cpp
Outdated
| if(path == nullptr) | ||
| return u""; | ||
|
|
||
| // Convert UTF-8 to UTF-16 |
|
I have it in a separated project, when i know a good way to included i will push it |
|
Hi, @psjuan97 ! At this point we need to find a way to deal with "android-spaghetti" cause by gradle, java, and swarm of xml's Logically, where we want to be:
To be clear, all above ^ it's a direction, where I think we want to end-up. It probably will take quite a work and several iterations to cleanup android build system issues.
|
|
Hi @Try What do you think about creating a new project for the "complex" platform that includes OpenGothic as a submodule? Something like this: MyAndroidGame/ (The Wrapper Project) So we separate the full Android (or iOS , etc.) build between the game and the platform-project. The main project will only generate a binary, so the responsibility of packing the binary in the correct way for each platform is for the new repository, no the game repo. |
|
Hi, That's definitely doesn't look like a nice solution. While you can go for something-like, for your own sake, but it's mater of time, before upstream will get misaligned with you external project. Like I've mentioned before: it best to have solution, that is not "special", and works same as ios/windows/mac/etc. Why don't you want to use CMake based generator? CMake has unit-test based on one of jni samples here: https://git.jukie.net/oss/cmake/-/tree/v3.30.8/Tests/VSAndroid |
|
Hi @Try, No, don't get me wrong, it's not that I don't want to use cmake, I just wanted to put another new idea on the table. I just uploaded a prototype to generate a Gradle project (compatible with Android Studio) using cmake and a input template, as IOS. Take a look. I'm open to modifications. PS: This link isn't working for me https://git.jukie.net/oss/cmake/-/tree/v3.30.8/Tests/VSAndroid |
|
Hi, @psjuan97 ! Yes, new solution look much more promising! Generally as-is it already solves build part. Would be nice to eventually move generator into Tempest. I haven't noticed gradle-wrapper.jar - it's not required anymore?
Hm, strange. Here, same thing as zip: cmake-v3.30.8-Tests-VSAndroid.zip |
I see it can be installed in the system and is not necesary to distribute the binary. I think that for this first version maybe is a good idea. So if you need that i change something more, just tell me! |
Yes, removing executable files from source repo is always good idea :) |
No description provided.