Add Docker support with Dockerfile and docker-compose#24
Merged
Conversation
Add multi-stage Dockerfile, docker-compose.yml, and .dockerignore for easy containerized deployment of the TAP HTTP server. Persistent storage for keys, databases, and logs is mapped to a single /data/tap volume. https://claude.ai/code/session_01NrmQxebTcQsNZeR2a9FnQn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive Docker support to tap-http, making it easier to deploy and run the application in containerized environments. The changes include a multi-stage Dockerfile for efficient builds, a docker-compose configuration for quick local development, and updated documentation.
Key Changes
Dockerfile: Multi-stage build that compiles tap-http in a Rust builder image and packages it in a minimal Debian runtime image
/data/tapfor keys, logs, and databasestap-httpandtap-payment-simulatorbinariesdocker-compose.yml: Simple configuration for local development
.dockerignore: Excludes unnecessary files from the build context
README.md: Added comprehensive Docker section with:
Notable Implementation Details
TAP_HTTP_HOST=0.0.0.0to allow external connections in containerstap-http --helpas a simple liveness probehttps://claude.ai/code/session_01NrmQxebTcQsNZeR2a9FnQn