Integrated SSL support. Modified echo example.#106
Open
lgg2 wants to merge 4 commits intoTheldus:masterfrom
Open
Integrated SSL support. Modified echo example.#106lgg2 wants to merge 4 commits intoTheldus:masterfrom
lgg2 wants to merge 4 commits intoTheldus:masterfrom
Conversation
… and must compile the "always" (`ws`) version. It is only a bit more difficult to read the code by the conditions, but same use and implpementation.
Owner
|
Hi @lgg2, At the moment, I’m a bit busy and also involved in another open-source project, so it may take me some time to review this PR. There are a few aspects of this PR that concern me, such as commented-out code and similar issues, but please leave it as it is, and I’ll review it when I have the time. Additionally, since SSL support is a sensitive feature, I plan to give it special attention when I can. I appreciate your patience, and I kindly ask you to keep this PR open. |
|
I can attest that this patch works and works well. I included it in my project and works fantastically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Again and again. This must work. Minimal changes made.
To
ws, skip to including thecertandcert_keypaths (or blank string) inws_socketcall struct.To
wssinclude a valid certificate and key for it.I have include a
localhostcertificate to test. It must be added a exception in the browser. For this, run theechoexample in wss mode and tell to the browser to add a exception overhttps://localhost:8080(in case of default values). After, it will work without problems.