Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR integrates a new “flash-imagen” image generation path using Google Gemini Flash and experiments with the Imagen 3 API. Key changes include:
- Added
*image-cacheatom withclear-image-cache!to manage generated image URLs. - Introduced
call-flash-imagen-msg!andcall-imagen-3-msg!handlers and updated UI dispatch and menu entries. - Cleaned up legacy Gemini Flash model mapping and adjusted HTTP config endpoints.
| -> state (assoc :answer @*text) (assoc :loading? false) (assoc :done? false) | ||
| recur | ||
| |call-gemini-msg! $ %{} :CodeEntry (:doc "|switching to Google's generative-ai-js sdk") | ||
| |call-flash-imagen-msg! $ %{} :CodeEntry (:doc |) |
There was a problem hiding this comment.
[nitpick] The call-flash-imagen-msg! entry has an empty :doc string; consider providing a concise description of its purpose and parameters.
Suggested change
| |call-flash-imagen-msg! $ %{} :CodeEntry (:doc |) | |
| |call-flash-imagen-msg! $ %{} :CodeEntry (:doc "|Generates content using the Flash Imagen model. Accepts a variant, cursor, state, prompt text, and a dispatch function. Updates the application state and handles asynchronous operations.") |
| d! $ :: :states cursor | ||
| -> state (assoc :answer @*text) (assoc :loading? false) (assoc :done? true) | ||
| |call-imagin-msg! $ %{} :CodeEntry (:doc |) | ||
| |call-imagen-3-msg! $ %{} :CodeEntry (:doc |) |
There was a problem hiding this comment.
[nitpick] The call-imagen-3-msg! entry also has an empty :doc string; adding a clear docstring would improve readability and maintainability.
Suggested change
| |call-imagen-3-msg! $ %{} :CodeEntry (:doc |) | |
| |call-imagen-3-msg! $ %{} :CodeEntry (:doc "|Generates images using the Imagen 3.0 model and updates the application state with the generated image or error status.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.