🔧 fix(lyrics): update Google Custom Search API endpoint#19
Open
E-B3rry wants to merge 2 commits intoTechcatchers:masterfrom
Open
🔧 fix(lyrics): update Google Custom Search API endpoint#19E-B3rry wants to merge 2 commits intoTechcatchers:masterfrom
E-B3rry wants to merge 2 commits intoTechcatchers:masterfrom
Conversation
The site_restricted_api will soon be dead and can currently only be used by old customers. Tested a typical search engine on my end, restricted to all the websites made to be scraped and all the three tests passed.
|
Thank you for this. |
| 'lyricsmint': scraper_factory.lyricsmint_scraper, | ||
| } | ||
|
|
||
| headers = { |
There was a problem hiding this comment.
Why do you need to pass the user agent? Is this only to trick the websites thinking it's a legitimate user so it doesn't get blocked by the firewalls?
Does it fail without this header?
|
@i-vis Can you please raise a PR for the same. I'll merge the same from my other account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #18
The site_restricted_api will soon be dead and can currently only be used by old customers, simple fix using the non restricted one by editing the endpoint url.
Tested a typical search engine on my end, restricted to all the websites made to be scraped and all the three tests passed.