fix: correct behaviors of control events#696
Merged
Mivik merged 9 commits intoTeamFlos:mainfrom Mar 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes RPE control-event easing behavior by aligning how easing/tween functions are associated with control keyframe intervals to match RPE’s “easing applies to the interval ending at this event” semantics.
Changes:
- Shift control-event tween assignment by one event so each keyframe uses the next event’s easing for the interval
[kf[i], kf[i+1]]. - Build an explicit
tweensvector and zip it with control-event keyframes when constructingAnimFloat.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Mivik
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix for behaviors of control events. Previously, the application failed to correctly assign the specified tweens to their corresponding intervals, resulting in inconsistency with RPE. In this PR, the tweens array is shifted by one position before joining with other properties, so as to align with the behaviors seen in RPE.