Fix SyncNet API call in train.py: get_vision_embed -> get_image_embed#406
Open
Mr-Neutr0n wants to merge 1 commit intoTMElyralab:mainfrom
Open
Fix SyncNet API call in train.py: get_vision_embed -> get_image_embed#406Mr-Neutr0n wants to merge 1 commit intoTMElyralab:mainfrom
Mr-Neutr0n wants to merge 1 commit intoTMElyralab:mainfrom
Conversation
The SyncNet model defines `get_image_embed()` in musetalk/models/syncnet.py, but train.py incorrectly calls `get_vision_embed()`, which does not exist. This causes an AttributeError at runtime when `use_adapted_weight` is enabled. The loss module (musetalk/loss/syncnet.py) already uses the correct method name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
train.pycallssyncnet.get_vision_embed()(line 232), but the SyncNet model (musetalk/models/syncnet.py) defines the method asget_image_embed(). This causes anAttributeErrorat runtime whenuse_adapted_weightis enabled during training.get_vision_embedtoget_image_embedto match the actual SyncNet API.musetalk/loss/syncnet.py) already uses the correctget_image_embed()name, confirming this is a typo intrain.py.Test plan
train.pyruns withoutAttributeErrorwhenuse_adapted_weightis enabledget_vision_embedremain