Skip to content

fix(tooltip): removed aria-expanded attribute #319 #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mart-sessman merged 1 commit into from
Mar 10, 2026
Merged

fix(tooltip): removed aria-expanded attribute #319 #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions tedi/components/overlay/tooltip/tooltip-trigger/tooltip-trigger.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { Renderer2 } from "@angular/core";

class MockTooltipComponent {
descriptionId = "mock-tooltip-id";
isOpen = jest.fn(() => false);
isContentHovered = jest.fn(() => false);
timeoutDelay = jest.fn(() => 100);
hideTimeout?: ReturnType<typeof setTimeout>;
Expand Down Expand Up @@ -227,25 +226,13 @@ describe("TooltipTriggerComponent", () => {
expect(btn.getAttribute("tabindex")).toBe("2");
});

it("should set ARIA attributes on interactive element when closed", () => {
it("should set aria-describedby on interactive element", () => {
hostEl.innerHTML = `<button>Click me</button>`;
const btn = hostEl.querySelector("button")!;
component.ngAfterContentChecked();
fixture.detectChanges();

expect(btn.getAttribute("aria-describedby")).toBe("mock-tooltip-id");
expect(btn.getAttribute("aria-expanded")).toBe("false");
});

it("should set aria-expanded to true when tooltip is open", () => {
tooltip.isOpen = jest.fn(() => true);
hostEl.innerHTML = `<button>Click me</button>`;
const btn = hostEl.querySelector("button")!;
component.ngAfterContentChecked();
fixture.detectChanges();

expect(btn.getAttribute("aria-describedby")).toBe("mock-tooltip-id");
expect(btn.getAttribute("aria-expanded")).toBe("true");
});
});
});
6 changes: 1 addition & 5 deletions tedi/components/overlay/tooltip/tooltip-trigger/tooltip-trigger.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,7 @@ export class TooltipTriggerComponent implements AfterContentChecked {
const element = this.interactiveElement();
if (!element) return;

const descriptionId = this.tooltip.descriptionId;
const isOpen = this.tooltip.isOpen();

element.setAttribute("aria-describedby", descriptionId);
element.setAttribute("aria-expanded", String(isOpen));
element.setAttribute("aria-describedby", this.tooltip.descriptionId);
});
}

Expand Down