chrisharper22's submission for Challenge 2#5
Open
chrisharper22 wants to merge 2 commits intoSwiftUI-Animation-Challenges:mainfrom
Open
chrisharper22's submission for Challenge 2#5chrisharper22 wants to merge 2 commits intoSwiftUI-Animation-Challenges:mainfrom
chrisharper22 wants to merge 2 commits intoSwiftUI-Animation-Challenges:mainfrom
Conversation
Contributor
|
Not only is the animation on point, but I also love the detailed explanation and the architectural thoughts that went into it. That's definitely bonus points that you receive there. :) Will love to talk about that tonight in the live stream! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my submission for the second challenge.
There are some things to take note of here:
Taskextension is used to allow seconds instead of nanoseconds (because I hate it).ProgressViewStyleis included, which I haven't seen much of anywhere.ProgresViewstyles are possible, which I'm assuming isn't common knowledge.initmethods for further reusability (which I guess would be beyond the scope of these challenges?)AirDropAvatarViewModel) is (mostly) documented with code comments.Here's what it looks like:
Challege.2.mov