Open
Conversation
Comment on lines
73
to
75
| } else { | ||
| view | ||
| } |
Author
There was a problem hiding this comment.
Is not clear to me how the animations would look like if we don't apply geometryGroup() and new animations are created. But probably we can leave that to a separate PR, in case the animations are unacceptable.
Member
There was a problem hiding this comment.
We can define our own geometryGroup() for pre-iOS 17 that applies the identify transform, which has the same effect.
Author
|
I reverted back to swift-tools-version to 5.8 since 6.0 requires too many changes for strict concurrency. |
wtmoose
requested changes
Dec 10, 2024
|
|
||
| import SwiftUI | ||
|
|
||
| extension View { |
Member
There was a problem hiding this comment.
Can you changes this to the following (to match what we use in Bootstrap)?
/// Provides a way to introduce a code block as a view modifier.
@ViewBuilder func map<Content: View>(@ViewBuilder _ transform: (Self) -> Content) -> some View {
transform(self)
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update swift-tools-version: 6.0