Skeletal Summary 2: Electric Boogaloo#313
Merged
Supreeeme merged 4 commits intoSupreeeme:mainfrom Mar 4, 2026
Merged
Conversation
ImSapphire
force-pushed
the
skeletal-summary
branch
4 times, most recently
from
9de70d9 to
23260f8
Compare
Supreeeme
reviewed
Feb 19, 2026
Contributor
ImSapphire
force-pushed
the
skeletal-summary
branch
2 times, most recently
from
1a5bb4f to
f79faf7
Compare
ImSapphire
force-pushed
the
skeletal-summary
branch
3 times, most recently
from
01b7488 to
0aa66b0
Compare
This is a direct port of OC's implementation, which isn't perfect. The calculated curl is not correct for the thumb, and on Quest the curl for the other fingers seems to max out at 0.8, but it's good enough to get gestures working in VRChat on Knuckles. Co-authored-by: Sapphire <imsapphire0@gmail.com>
ImSapphire
force-pushed
the
skeletal-summary
branch
from
0aa66b0 to
ec55641
Compare
Contributor
|
Double checked since there's been a few pushes - can confirm that this still solves the Dungeons of Eternity gripping issue w/ Index Controllers. |
Supreeeme
reviewed
Mar 4, 2026
Owner
Supreeeme
left a comment
Supreeeme
left a comment
There was a problem hiding this comment.
This could probably use some tests of some kind, but I won't block this on that for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #69, containing some (slightly reworked) commits from #261.
Hand skeleton is cached, but the separate path for estimated summary is still there, since the bone transforms are in OpenVR coordinate space and it feels wrong converting them back...
Closes #258
Part of #251
Part of #256