[#305] Add OpenVR v0.9.19 for BoneWorks#306
Conversation
BoneWorks requires `IVRCompositor_013` & v0.9.19 is the latest version that supports it. Additionally, pulled in `IVRSettings_001`, since that is defined in v0.9.19 as well.
prikhi
left a comment
prikhi
left a comment
There was a problem hiding this comment.
Yet another Compositor_FrameTiming. And dumb stubs for the new settings interface included in this version since we don't actually track/modify settings values. All other interface versions found in .19 either don't exist in the code at all or have been implemented already from past/future versions.
| _default_value: bool, | ||
| error: *mut EVRSettingsError, | ||
| ) -> bool { | ||
| vr::IVRSettings003_Interface::GetBool(self, section, settings_key, error) |
There was a problem hiding this comment.
These just call the latest interface functions, which don't take the default_value params. They just return constant values(e.g., false) instead of actually storing/fetching settings.
Is that weird? Should we have like a HashMap<String, HashMap<String, SettingsValue>> that we utilize as we receive Set & Get calls? Does anything ever care about these settings?
|
@Supreeeme this wasn't actually needed to get the game to work(oddly it requests 2 diff versions of ivrcompositor & is fine running w/ one of the versions we already implement), so up to you if you wanna merge or just close this out. |
1 participant
BoneWorks requires
IVRCompositor_013& v0.9.19 is the latest version that supports it.Additionally, pulled in
IVRSettings_001, since that is defined in v0.9.19 as well.Closes #305 but don't have game so will need verification from issue submitter.