fix(button): adjust disabled state style in HC modes #2160
+714
−646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f74079c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mukunku
reviewed
Jan 30, 2026
Collaborator
mukunku
left a comment
mukunku
left a comment
There was a problem hiding this comment.
I noticed the border color is black-600 in the designs for HC light mode for tonal and base but you have black-300. Other than that everything seems to match the designs.
CGuindon
requested changes
Jan 30, 2026
Collaborator
CGuindon
left a comment
CGuindon
left a comment
There was a problem hiding this comment.
I like most of the changes you made with the non-50 stops.
- For HC Dark and HC Light mode on
s-btn s-btn--badge— the badge color should be black-300 (I think you went one stop the other direction). That will match what we have now on Dark/Light mode as well which is nice.
* fix border colors for hc * update baseline * Update button.less
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPARK-143
This PR updates the styles of button disabled states in HC modes according to the Figma spec
It also make sure that for the
baseandbase clearbutton variant we exclusively usetheme-secondarycolor step which don't havex50s steps. Therefore for those 2 variants you could observe some slight difference compared to what is in Figma.Buttons Docs Page (PR Env)