-
Notifications
You must be signed in to change notification settings - Fork 102
feat(sidebar-widget): initial SHINE design changes #2155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 38625af The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
giamir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mukunku
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The sidebar is 344px without any padding so the sidebar widgets shouldn't have left/right padding. That spacing will be handled on the outside of the whole right sidebar.
-
Add
s-btn s-btn__xs s-btn__clearto thes-sidebarwidget--action(the + track button) element so that it gets the button stylings for height and hover states. -
Then you're padding between the header and middle container can be a normal 12px class (instead of 16 + 2, because the button will make the header container taller).
(screenshot shows hover state)
- Should the text inside
s-sidebarwidget--contentbe in aelement? (not 100% but wondering about a11y or html standards with text if it's needed here or not)
-
Title: There's a space before "Community Achievements" that shouldn't be there (made me think there was extra padding) and the title should be
fw-medium(instead of bold). -
(more rare use case but thinking of future proofing) Can we have the icon be it's own "column" on the left in the header? So that if the title needs to wrap to a second line, the text wouldn't wrap under the icon.
-
AND make sure there's at least 6px padding in between the title and the button on the right (so if the title does get long, it won't touch the button's edge).
Popped that second example in the Figma
- I feel like the warning note should be above the example not after (easier to miss) — that means 2 notices before, I think that's fine.
|
Thanks for the review @CGuindon ! I believe I addressed all your comments:
|
CGuindon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no Svelte component right? Should there be? or is this a different ticket? Approving the Stacks CLassic version so you can merge
Summary
This PR removes a few of the existing sidebar widget functionality while salvaging what I could and updating it according to the new SHINE designs.
A lot of the old variations might not be relevant anymore so the idea is to add them back on a case-by-case basis as needed. The reason they were removed was because it didn't make sense to spend effort on them without proper designs.
How to Test
Check out the Sidebar Widgets page: https://deploy-preview-2155--stacks.netlify.app/product/components/sidebar-widgets/