Open
Conversation
b9a8fbc to
c61cbd0
Compare
c61cbd0 to
1464141
Compare
lukegb
reviewed
Jan 1, 2019
bb8dc35 to
0a3891f
Compare
0a3891f to
cb674ac
Compare
gabizou
approved these changes
Jan 28, 2019
Member
gabizou
left a comment
There was a problem hiding this comment.
While the worry of letting people potentially confuse users with names like _gabizou or _gabizou_, I feel that staff as a whole could moderate those users since the user who tries to register with that name would more than likely be doing so facetiously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discussed username validation a bit with Snowie after we got a user with a dot in the name which introduced some trouble.
New username rules would be:
a-zA-z0-9-_-__test__)Allowed examples:
_test_bettertest_this-is-a-testiamprettynormalI_am_specialNot allowed anymore:
I.am.a.testBefore we also allowed usernames to contain
.which will be disabled with this PR.However this PR now allows usernames to end with
_. This is maybe controversial but sinceewoutvs_has this in his name as staff member, we should allow it.