Update config, use string literal for Protobuf Gradle plugin ID#16
Merged
alexander-yevsyukov merged 14 commits intomasterfrom Sep 18, 2025
Merged
Update config, use string literal for Protobuf Gradle plugin ID#16alexander-yevsyukov merged 14 commits intomasterfrom
config, use string literal for Protobuf Gradle plugin ID#16alexander-yevsyukov merged 14 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates configuration dependencies and improves the Plugin class by replacing dynamic dependency references with hardcoded string constants for better maintainability and reliability.
- Updates the project version from 0.12.0 to 0.13.0 across all configuration files
- Replaces dynamic Protobuf Gradle plugin ID with static string literal "com.google.protobuf"
- Refactors configuration directory structure and updates Gradle build settings
Reviewed Changes
Copilot reviewed 70 out of 74 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Updates project version from 0.12.0 to 0.13.0 |
| gradle-plugin/src/main/kotlin/io/spine/tools/prototap/gradle/Plugin.kt | Replaces dynamic plugin ID reference with hardcoded string constant |
| pom.xml | Updates version references and dependency versions including JUnit upgrade |
| gradle.properties | Improves Gradle configuration with better memory settings and parallel builds |
| settings.gradle.kts | Removes Foojay toolchain plugin configuration |
| buildSrc/* | Extensive configuration updates and new build script plugins |
| dependencies.md | Auto-generated dependency report updates |
| config | Updates Git submodule commit reference |
Files not reviewed (1)
- .idea/dictionaries/common.xml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
armiol
requested changes
Sep 18, 2025
| @@ -34,10 +34,8 @@ package io.spine.tools.prototap.gradle | |||
| import com.google.common.annotations.VisibleForTesting | |||
| import com.google.protobuf.gradle.GenerateProtoTask | |||
| import com.google.protobuf.gradle.id | |||
Contributor
Author
There was a problem hiding this comment.
This is the extension function imported:
fun <T : Any> NamedDomainObjectContainer<T>.id(id: String, action: (T.() -> Unit)? = null) {
action?.let { create(id, it) } ?: create(id)
}We use it here:
private fun GenerateProtoTask.addProtocPlugin() {
plugins.apply {
id(PROTOC_PLUGIN_NAME) { // <----- HERE
val path = project.codeGeneratorRequestFile
val encoded = path.base64Encoded()
option(encoded)
}
}
}
armiol
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
configand make thePluginclass use string constant for the Protobuf Gradle Plugin ID.