Skip to content

fix: remove insecure headless mode usage #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoClosee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove insecure headless mode usage #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions freework_scraper/scraper/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
"""Cross-platform Selenium browser manager for FreeWork scraper."""

from __future__ import annotations

import logging
Expand All @@ -18,7 +16,7 @@
class BrowserManager:
"""Manages Selenium Chrome browser lifecycle — Windows, Mac & Linux."""

def __init__(self, headless: bool = True):
def __init__(self, headless: bool = False):
self.headless = headless
self.driver: webdriver.Chrome | None = None

Expand Down Expand Up @@ -82,7 +80,7 @@ def get(self, url: str) -> None:
self.driver.get(url)

@property
def page_source(self) -> str:
def page_source(self) -> str:
"""Get current page HTML source."""
if not self.driver:
raise RuntimeError("Browser not started.")
Expand All @@ -104,4 +102,4 @@ def __enter__(self) -> BrowserManager:
return self

def __exit__(self, *args) -> None:
self.quit()
self.quit()