Skip to content

fix: 修复组件 Carousel 不刷新 children 的问题 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iChengbo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: 修复组件 Carousel 不刷新 children 的问题 #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/Carousel/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ export class Carousel extends React.PureComponent {

componentWillReceiveProps(nextProps) {

// when data changes, children should be re-generated
if(nextProps.data !== this.props.data) {
// when data or children changes, children should be re-generated
if(nextProps.data !== this.props.data || nextProps.children !== this.props.children) {
this.setState({children: Helper.makeChildren(nextProps)});
}

Expand Down